Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

invalid item name warning: use file or folder when appropriate #6602

Merged
merged 1 commit into from
Apr 28, 2024
Merged

invalid item name warning: use file or folder when appropriate #6602

merged 1 commit into from
Apr 28, 2024

Conversation

mgallien
Copy link
Collaborator

@mgallien mgallien commented Apr 2, 2024

No description provided.

@mgallien
Copy link
Collaborator Author

mgallien commented Apr 2, 2024 •
edited
Loading

before
image

after
image

@mgallien mgallien force-pushed the bugfix/clarifyInvalidFileNamesWarning branch from f84148f to a15502a Compare April 2, 2024 10:07
jancborchardt
jancborchardt approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good!

Btw @mgallien the text is not vertically aligned with the icon but a bit too much to the top.

@mgallien mgallien force-pushed the bugfix/clarifyInvalidFileNamesWarning branch from a15502a to 70f4f64 Compare April 11, 2024 11:08
@mgallien mgallien force-pushed the bugfix/clarifyInvalidFileNamesWarning branch from 70f4f64 to acb8e03 Compare April 26, 2024 09:15
@claucambra claucambra force-pushed the bugfix/clarifyInvalidFileNamesWarning branch from acb8e03 to 7262d11 Compare April 28, 2024 08:57
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6602-7262d11f4710bac339005c2da20cee499caff659-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@claucambra claucambra merged commit 6a6d92d into master Apr 28, 2024
8 of 12 checks passed
@claucambra claucambra deleted the bugfix/clarifyInvalidFileNamesWarning branch April 28, 2024 09:01
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
17 New Code Smells (required ≤ 0)
E Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claucambra claucambra claucambra approved these changes

@jancborchardt jancborchardt jancborchardt approved these changes

@camilasan camilasan Awaiting requested review from camilasan

@allexzander allexzander Awaiting requested review from allexzander

@nimishavijay nimishavijay Awaiting requested review from nimishavijay

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mgallien @nextcloud-desktop-bot @jancborchardt @claucambra